Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: build/gyp_helper.py

Issue 931643002: gyp: chromium.gyp_env behaves like .gyp/include.gypi (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ', not " Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_helper.py
diff --git a/build/gyp_helper.py b/build/gyp_helper.py
index 645943a0183217b955e79af284e842ab3bee883d..a2cc7e19cbc3578ba863e9ea214af78dafd48846 100644
--- a/build/gyp_helper.py
+++ b/build/gyp_helper.py
@@ -42,8 +42,12 @@ def apply_gyp_environment_from_file(file_path):
file_val = file_data.get(var)
if file_val:
if var in os.environ:
- print 'INFO: Environment value for "%s" overrides value in %s.' % (
- var, os.path.abspath(file_path)
+ behavior = 'replaces'
+ if var == 'GYP_DEFINES':
+ os.environ[var] = file_val + ' ' + os.environ[var]
+ behavior = 'overrides'
+ print 'INFO: Environment value for "%s" %s value in %s' % (
+ var, behavior, os.path.abspath(file_path)
)
else:
os.environ[var] = file_val
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698