Update the thumbnail when a file is updated.

Update the thumbnail when a file is updated.

BUG=456016
TEST=With opening a file manager, edit a file. Thumbnail will be updated.

Committed: https://crrev.com/55d2e68012f85d763dd70347895f5e9768c6a1c6
Cr-Commit-Position: refs/heads/master@{#316536}

[yawano, 2015-02-16 11:22:55]

yawano@chromium.org changed reviewers:
+ hirono@chromium.org

[yawano, 2015-02-16 11:22:55]

PTAL. Thank you!

[hirono, 2015-02-16 12:33:17]

https://codereview.chromium.org/931603002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/directory_contents.js (right):

https://codereview.chromium.org/931603002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_contents.js:711: * @param
{Object} metadataSnapshot A metadata snapshot.
nit: @param {!Object} ?

https://codereview.chromium.org/931603002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_contents.js:739: var
entries = Object.keys(newMetadataSnapshot);
nit: entries sounds like Array<Entry>. Can we rename it with entryURLs?

https://codereview.chromium.org/931603002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_contents.js:746:
updatedIndexes.push(i);
The entries are produced by Object.keys, and the items in entries appears in
different order from the this.fileList_. So we cannot use index i for
fileList_.updateIndexes.

[yawano, 2015-02-17 02:16:29]

Thank you for the review! PTAL.

https://codereview.chromium.org/931603002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/directory_contents.js (right):

https://codereview.chromium.org/931603002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_contents.js:711: * @param
{Object} metadataSnapshot A metadata snapshot.
On 2015/02/16 12:33:16, hirono wrote:
> nit: @param {!Object} ?

Done.

https://codereview.chromium.org/931603002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_contents.js:739: var
entries = Object.keys(newMetadataSnapshot);
On 2015/02/16 12:33:16, hirono wrote:
> nit: entries sounds like Array<Entry>. Can we rename it with entryURLs?

Done.

https://codereview.chromium.org/931603002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_contents.js:746:
updatedIndexes.push(i);
On 2015/02/16 12:33:16, hirono wrote:
> The entries are produced by Object.keys, and the items in entries appears in
> different order from the this.fileList_. So we cannot use index i for
> fileList_.updateIndexes.
> 

Done.

[hirono, 2015-02-17 03:14:13]

lgtm!

[yawano, 2015-02-17 03:15:18]

On 2015/02/17 03:14:13, hirono wrote:
> lgtm!

Thank you!

[yawano, 2015-02-17 03:15:23]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2015-02-17 03:16:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/931603002/20001

[commit-bot: I haz the power, 2015-02-17 04:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-17 04:14:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yawano, 2015-02-17 05:02:51]

New patchsets have been uploaded after l-g-t-m from hirono@chromium.org

[yawano, 2015-02-17 05:33:38]

The previous patch set broke the test case. I fixed it with the new patch set.
The cause of breaking the test case is that I changed ListThumbnailLoader to use
getLatest call instead of getOne. PTAL. Thank you!

[hirono, 2015-02-17 06:25:58]

still lgtm!

[yawano, 2015-02-17 06:26:54]

On 2015/02/17 06:25:58, hirono wrote:
> still lgtm!

Thank you!

[yawano, 2015-02-17 06:26:58]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2015-02-17 06:27:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/931603002/40001

[commit-bot: I haz the power, 2015-02-17 06:30:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-17 06:31:18]

Patchset 3 (id:??) landed as
https://crrev.com/55d2e68012f85d763dd70347895f5e9768c6a1c6
Cr-Commit-Position: refs/heads/master@{#316536}