Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 931583003: Add TypeChecking=Unrestricted to SVGElements where applicable (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
CC:
darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, krit, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, f(malita), gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, Mike Lawther (Google), pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add TypeChecking=Unrestricted to SVGElements where applicable Affects the following methods: SVGAnimationElement.beginElementAt(float offset) SVGAnimationElement.endElementAt(float offset) SVGFEDropShadowElement.setStdDeviation(float ..., float ...) SVGFEGaussianBlurElement.setStdDeviation(float ..., float ...) The new behavior matches Gecko. Adjust the test svg/custom/elementTimeControl-nan-crash.html to handle the exception and make it call dumpAsText earlier. BUG=354298, 311246 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M LayoutTests/svg/custom/elementTimeControl-nan-crash.html View 1 chunk +5 lines, -4 lines 0 comments Download
M LayoutTests/svg/dom/method-argument-typechecks.html View 2 chunks +8 lines, -4 lines 0 comments Download
M LayoutTests/svg/dom/method-argument-typechecks-expected.txt View 1 chunk +12 lines, -8 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.idl View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
5 years, 10 months ago (2015-02-16 17:14:13 UTC) #2
Erik Dahlström (inactive)
lgtm, for completeness might be good to add a test using Infinity for begin/endElementAt too.
5 years, 10 months ago (2015-02-17 13:59:35 UTC) #3
fs
On 2015/02/17 13:59:35, Erik Dahlström wrote: > lgtm, for completeness might be good to add ...
5 years, 10 months ago (2015-02-17 14:05:28 UTC) #4
pdr.
LGTM2
5 years, 10 months ago (2015-02-17 22:32:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931583003/1
5 years, 10 months ago (2015-02-17 22:33:43 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:38:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190359

Powered by Google App Engine
This is Rietveld 408576698