Source/bindings/tests/results/core/V8TestInterface.cpp - Issue 931543002: Disallow wrapper creation from visitDOMWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 931543002: Disallow wrapper creation from visitDOMWrapper (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/core/V8TestInterface.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterface.cpp b/Source/bindings/tests/results/core/V8TestInterface.cpp

index 1d4079b64827cb7e55e2db7aa3c87fa6e4e2a7eb..40a8e47e5f2f950b35dd9621219cdd5dd366e300 100644

--- a/Source/bindings/tests/results/core/V8TestInterface.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterface.cpp

@@ -1968,8 +1968,7 @@ void V8TestInterface::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* scr

V8WrapperInstantiationScope scope(creationContext, isolate);

TestInterfaceImplementation* referencedName = impl->referencedName();

if (referencedName) {

- if (!DOMDataStore::containsWrapper(referencedName, isolate))

- referencedName->wrap(creationContext, isolate);

+ RELEASE_ASSERT(DOMDataStore::containsWrapper(referencedName, isolate));

DOMDataStore::setWrapperReference(wrapper, referencedName, isolate);

}

setObjectGroup(isolate, scriptWrappable, wrapper);