Source/bindings/templates/interface.cpp - Issue 931543002: Disallow wrapper creation from visitDOMWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/interface.cpp

Issue 931543002: Disallow wrapper creation from visitDOMWrapper (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: RELEASE_ASSERT Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/interface.cpp

diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp

index 5da47a89b6533626e3f90a0aa2fd535dfe2c64cc..d0fcfb7cad4c46d964d5da50f19a83d65cccec5d 100644

--- a/Source/bindings/templates/interface.cpp

+++ b/Source/bindings/templates/interface.cpp

@@ -596,8 +596,7 @@ void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* script

{% for set_wrapper_reference_to in set_wrapper_reference_to_list %}

{{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = impl->{{set_wrapper_reference_to.name}}();

if ({{set_wrapper_reference_to.name}}) {

- if (!DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, isolate))

- {{set_wrapper_reference_to.name}}->wrap(creationContext, isolate);

+ RELEASE_ASSERT(DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, isolate));

haraken 2015/02/16 06:05:39 Add a comment on why this needs to be release-asse

DOMDataStore::setWrapperReference(wrapper, {{set_wrapper_reference_to.name}}, isolate);

}

{% endfor %}

« no previous file with comments | « no previous file | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »