Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 931533002: Make callback optional. (Closed)

Created:
5 years, 10 months ago by rpaquay
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callback optional. BUG=358315 See comment #20: https://code.google.com/p/chromium/issues/detail?id=358315#c20 Committed: https://crrev.com/c1afd59c8551e26fdfab44dd51bdc7d015be23da Cr-Commit-Position: refs/heads/master@{#316681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/browser.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-17 19:12:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931533002/1
5 years, 10 months ago (2015-02-17 21:21:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 22:37:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:38:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1afd59c8551e26fdfab44dd51bdc7d015be23da
Cr-Commit-Position: refs/heads/master@{#316681}

Powered by Google App Engine
This is Rietveld 408576698