Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2574)

Issue 931503002: Cleanup: Move sqlite_persistent_cookie_store_perftest.cc into content_perftests target. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Move sqlite_persistent_cookie_store_perftest.cc into content_perftests target. BUG=None TEST=perf_tests and content_perftests R=thestig@chromium.org,avi@chromium.org Committed: https://crrev.com/4ee38944c67548f1314f9fc1ef1363797b28bf02 Cr-Commit-Position: refs/heads/master@{#316627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -29 lines) Patch
M chrome/chrome_tests.gypi View 3 chunks +1 line, -25 lines 0 comments Download
M chrome/test/perf/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/perf/perftests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
I want to do a second pass to remove perf_tests target. But I want to ...
5 years, 10 months ago (2015-02-15 22:04:54 UTC) #1
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-17 16:24:29 UTC) #2
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-17 19:33:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931503002/1
5 years, 10 months ago (2015-02-17 19:34:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 19:38:45 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 19:39:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ee38944c67548f1314f9fc1ef1363797b28bf02
Cr-Commit-Position: refs/heads/master@{#316627}

Powered by Google App Engine
This is Rietveld 408576698