Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: dbus/message.h

Issue 9315006: Adding support for sending/receiving proto bufs to dbus library. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added in the DEPS file as suggested Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/dbus.gyp ('k') | dbus/message.cc » ('j') | dbus/test_proto.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/message.h
diff --git a/dbus/message.h b/dbus/message.h
index ceeb0edbf7a74f3417165f420c04539b5a8989a0..6bfa86760ed421d2b3251f83a1aa62b19131fa05 100644
--- a/dbus/message.h
+++ b/dbus/message.h
@@ -12,6 +12,15 @@
#include "base/basictypes.h"
+namespace google {
+namespace protobuf {
+
+class MessageLite;
+
+} // namespace protobuf
+} // namespace google
+
+
namespace dbus {
class MessageWriter;
@@ -294,6 +303,14 @@ class MessageWriter {
// specialized function.
void AppendArrayOfObjectPaths(const std::vector<std::string>& object_paths);
+ // Appends the protocol buffer as an array of bytes. The buffer is serialized
+ // into an array of bytes before communication, since protocol buffers are not
+ // a native dbus type. On the receiving size the array of bytes needs to be
+ // read and deserialized into a protocol buffer of the correct type. There are
+ // methods in MessageReader to assist in this. Return true on succes and fail
+ // when serialization is not successful.
+ bool AppendProtoAsArrayOfBytes(const google::protobuf::MessageLite& protobuf);
+
// Appends the byte wrapped in a variant data container. Variants are
// widely used in D-Bus services so it's worth having a specialized
// function. For instance, The third parameter of
@@ -392,6 +409,14 @@ class MessageReader {
// function.
bool PopArrayOfObjectPaths(std::vector<std::string>* object_paths);
+ // Gets the array of bytes at the current iterator position. It then parses
+ // this binary blob into the protocol buffer supplied.
+ // Returns true and advances the iterator on success. On failure returns false
+ // and emits an error message on the source of the failure. The two most
+ // common errors come from the iterator not currently being at a byte array or
+ // the wrong type of protocol buffer is passed in and the parse fails.
+ bool PopArrayOfBytesAsProto(google::protobuf::MessageLite* protobuf);
+
// Gets the byte from the variant data container at the current iterator
// position.
// Returns true and advances the iterator on success.
« no previous file with comments | « dbus/dbus.gyp ('k') | dbus/message.cc » ('j') | dbus/test_proto.proto » ('J')

Powered by Google App Engine
This is Rietveld 408576698