Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Issue 931483004: Update Chrome Launcher icons with new assets. (Closed)

Created:
5 years, 10 months ago by Matt Giuca
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, oshima+watch_chromium.org, Albert Bodenhamer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Chrome Launcher icons with new assets. The new assets have correct colour contrast and more closely match the Material Design spec. Affects both the classic and experimental launcher. The following assets were replaced: - Microphone (hotword enabled and disabled states). - Back button. - Download progress bar. BUG=457979, 456953 TBR=oshima@chromium.org Committed: https://crrev.com/8d50b3ae887a32fa31e18a8669ff2187a41e0b76 Cr-Commit-Position: refs/heads/master@{#316947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/app/theme/default_100_percent/common/app_list_mic_hotword_off.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/app_list_mic_hotword_on.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/app_list_mic_hotword_off.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/app_list_mic_hotword_on.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_resource_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/default_100_percent/common/app_list_folder_back_normal.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/app_list_progress_bar_background.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/app_list_progress_bar_center.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/app_list_progress_bar_left.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/app_list_progress_bar_right.png View Binary file 0 comments Download
M ui/resources/default_200_percent/common/app_list_folder_back_normal.png View Binary file 0 comments Download
M ui/resources/default_200_percent/common/app_list_progress_bar_background.png View Binary file 0 comments Download
M ui/resources/default_200_percent/common/app_list_progress_bar_center.png View Binary file 0 comments Download
M ui/resources/default_200_percent/common/app_list_progress_bar_left.png View Binary file 0 comments Download
M ui/resources/default_200_percent/common/app_list_progress_bar_right.png View Binary file 0 comments Download

Messages

Total messages: 12 (3 generated)
Matt Giuca
Forgot to send this out the other day. calamity: chrome/browser/ui/app_list/search/search_resource_manager.cc oshima: png and grd files
5 years, 10 months ago (2015-02-17 23:07:33 UTC) #2
Matt Giuca
sadrul: ui/resources owners. cpu: chrome/app owners. (oshima is OOO and this is needed for M41; ...
5 years, 10 months ago (2015-02-17 23:13:58 UTC) #4
sadrul
/cc+ abodenha@ rs lgtm
5 years, 10 months ago (2015-02-17 23:41:53 UTC) #5
calamity
lgtm
5 years, 10 months ago (2015-02-18 00:52:30 UTC) #6
Matt Giuca
cpu: Would you be able to look at this asap? (We're trying to land this ...
5 years, 10 months ago (2015-02-18 01:39:00 UTC) #7
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-18 16:05:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931483004/1
5 years, 10 months ago (2015-02-18 23:27:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 01:10:00 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:10:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d50b3ae887a32fa31e18a8669ff2187a41e0b76
Cr-Commit-Position: refs/heads/master@{#316947}

Powered by Google App Engine
This is Rietveld 408576698