Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: ui/gfx/path_win_unittest.cc

Issue 931463002: Remove SK_SUPPORT_LEGACY_ADDRRECT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: speculative win fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/skia_test_expectations.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/path_win_unittest.cc
diff --git a/ui/gfx/path_win_unittest.cc b/ui/gfx/path_win_unittest.cc
index 9ca4cf164cf1ebb094bdcb086cba9a081ad3cd5c..1c211d7dacebe51859fe0e265c7f98a92e6aece1 100644
--- a/ui/gfx/path_win_unittest.cc
+++ b/ui/gfx/path_win_unittest.cc
@@ -42,31 +42,36 @@ std::vector<SkIRect> GetRectsFromHRGN(HRGN region) {
// Test that rectangle with round corners stil has round corners after
// converting from SkPath to the HRGN.
+// FIXME: this test is fragile (it depends on rrect rasterization impl)
TEST(CreateHRGNFromSkPathTest, RoundCornerTest) {
const SkIRect rects[] = {
- { 17, 0, 33, 1},
- { 12, 1, 38, 2},
- { 11, 2, 39, 3},
- { 9, 3, 41, 4},
- { 8, 4, 42, 5},
- { 6, 5, 44, 6},
- { 5, 6, 45, 8},
- { 4, 8, 46, 9},
- { 3, 9, 47, 11},
- { 2, 11, 48, 12},
- { 1, 12, 49, 17},
- { 0, 17, 50, 33},
- { 1, 33, 49, 38},
- { 2, 38, 48, 39},
- { 3, 39, 47, 41},
- { 4, 41, 46, 42},
- { 5, 42, 45, 44},
- { 6, 44, 44, 45},
- { 8, 45, 42, 46},
- { 9, 46, 41, 47},
- { 11, 47, 39, 48},
- { 12, 48, 38, 49},
- { 17, 49, 33, 50},
+ { 16, 0, 34, 1 },
+ { 12, 1, 38, 2 },
+ { 10, 2, 40, 3 },
+ { 9, 3, 41, 4 },
+ { 7, 4, 43, 5 },
+ { 6, 5, 44, 6 },
+ { 5, 6, 45, 7 },
+ { 4, 7, 45, 8 },
+ { 4, 8, 46, 9 },
+ { 3, 9, 47, 10 },
+ { 2, 10, 47, 11 },
+ { 2, 11, 48, 12 },
+ { 1, 12, 49, 16 },
+ { 0, 16, 50, 34 },
+ { 1, 34, 49, 38 },
+ { 2, 38, 48, 39 },
+ { 2, 39, 47, 40 },
+ { 3, 40, 47, 41 },
+ { 4, 41, 46, 42 },
+ { 4, 42, 45, 43 },
+ { 5, 43, 45, 44 },
+ { 6, 44, 44, 45 },
+ { 8, 45, 42, 46 },
+ { 9, 46, 41, 47 },
+ { 11, 47, 39, 48 },
+ { 12, 48, 38, 49 },
+ { 16, 49, 34, 50 },
};
Path path;
« no previous file with comments | « skia/skia_test_expectations.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698