Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 931463002: Remove SK_SUPPORT_LEGACY_ADDRRECT (Closed)

Created:
5 years, 10 months ago by f(malita)
Modified:
5 years, 10 months ago
Reviewers:
robertphillips, reed1
CC:
chromium-reviews, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SK_SUPPORT_LEGACY_ADDRRECT TBR=reed@google.com,robertphillips@google.com BUG=458898 Committed: https://crrev.com/2214663a56798add41d6ac09a893c09c77b328ba Cr-Commit-Position: refs/heads/master@{#316504}

Patch Set 1 #

Patch Set 2 : layout test suppressions #

Patch Set 3 : rebased #

Patch Set 4 : more suppressions #

Patch Set 5 : speculative win fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+865 lines, -27 lines) Patch
M skia/config/SkUserConfig.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 2 3 1 chunk +837 lines, -0 lines 0 comments Download
M ui/gfx/path_win_unittest.cc View 1 2 3 4 1 chunk +28 lines, -23 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
f(malita)
I think this is ready to go, to be followed by https://codereview.chromium.org/932553003/ shortly (Blink rebaseline).
5 years, 10 months ago (2015-02-16 16:29:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931463002/60001
5 years, 10 months ago (2015-02-16 16:29:52 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-16 16:29:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931463002/60001
5 years, 10 months ago (2015-02-16 16:31:47 UTC) #8
robertphillips
lgtm
5 years, 10 months ago (2015-02-16 16:50:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931463002/60001
5 years, 10 months ago (2015-02-16 17:29:59 UTC) #12
f(malita)
Win failures look real: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/26872/steps/gfx_unittests/logs/stdio I'll investigate.
5 years, 10 months ago (2015-02-16 18:15:39 UTC) #13
f(malita)
On 2015/02/16 18:15:39, f(malita) wrote: > Win failures look real: > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/26872/steps/gfx_unittests/logs/stdio > > I'll ...
5 years, 10 months ago (2015-02-16 18:16:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/26881)
5 years, 10 months ago (2015-02-16 18:41:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931463002/80001
5 years, 10 months ago (2015-02-16 19:26:55 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-16 21:00:49 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 21:01:45 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2214663a56798add41d6ac09a893c09c77b328ba
Cr-Commit-Position: refs/heads/master@{#316504}

Powered by Google App Engine
This is Rietveld 408576698