Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 931393003: Fix breaking change in It2me Host on Ozone (Closed)

Created:
5 years, 10 months ago by kelvinp
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov, spang
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix breaking change in It2me Host on Ozone Due to a recent threading changes, the Ozone SystemInputInjector must be created on the UI thread. This CL moves the creation of the input injector and input controller on to the browser UI thread. BUG=458314 Committed: https://crrev.com/9c59eedd7720845a5bc93b6dbc72639305c52ea7 Cr-Commit-Position: refs/heads/master@{#316883} Committed: https://crrev.com/ab05ec8fc74d598df6cc5114eb9f657be54fca42 Cr-Commit-Position: refs/heads/master@{#316908}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix compile failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M remoting/host/input_injector_chromeos.cc View 1 2 4 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
kelvinp
PTAL
5 years, 10 months ago (2015-02-18 00:56:45 UTC) #2
spang
lgtm
5 years, 10 months ago (2015-02-18 01:41:53 UTC) #3
Sergey Ulanov
LGTM, but you will probably need to merge this with https://codereview.chromium.org/929493002/ (in CQ)
5 years, 10 months ago (2015-02-18 01:49:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931393003/20001
5 years, 10 months ago (2015-02-18 18:00:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 20:20:13 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9c59eedd7720845a5bc93b6dbc72639305c52ea7 Cr-Commit-Position: refs/heads/master@{#316883}
5 years, 10 months ago (2015-02-18 20:21:00 UTC) #9
spang
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/932233002/ by spang@chromium.org. ...
5 years, 10 months ago (2015-02-18 21:43:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931393003/40001
5 years, 10 months ago (2015-02-18 22:04:43 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-18 22:57:11 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 23:02:33 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab05ec8fc74d598df6cc5114eb9f657be54fca42
Cr-Commit-Position: refs/heads/master@{#316908}

Powered by Google App Engine
This is Rietveld 408576698