Remove net URLRequest trace events.

Remove net URLRequest trace events.

This CL removes URLRequest trace events tagged with category, "net".
URLRequest events are already logged by trace_net_log_observer.cc using the new
"netlog" category. This CL is a part of the effort to deprecate the old "net"
category.

BUG=456114
Committed: https://crrev.com/a079a1abb92e6c604eb3f73dfec62a48c8c4ec77
Cr-Commit-Position: refs/heads/master@{#318250}

[xunjieli, 2015-02-17 22:01:58]

xunjieli@chromium.org changed reviewers:
+ mmenkenduca@chromium.org

[xunjieli, 2015-02-17 22:05:03]

xunjieli@chromium.org changed reviewers:
+ mmenke@chromium.org, nduca@chromium.org
- mmenkenduca@chromium.org

[xunjieli, 2015-02-17 22:05:03]

I am going to deprecate "net" category in tracing in three steps:
#1. Remove "net" events in chrome/src/
#2. Remove "net" events from third_party/WebKit/
#3. Remove "disable-by-default-" prefix from "netlog" category.

This CL is #1. Let me know if you'd like me to do #3 before #1 & #2.

Thanks!

[mmenke, 2015-02-18 19:00:49]

On 2015/02/17 22:05:03, xunjieli wrote:
> I am going to deprecate "net" category in tracing in three steps:
> #1. Remove "net" events in chrome/src/
> #2. Remove "net" events from third_party/WebKit/
> #3. Remove "disable-by-default-" prefix from "netlog" category.
> 
> This CL is #1. Let me know if you'd like me to do #3 before #1 & #2.
> 
> Thanks!

You'll also want to remove the "net" section from about:tracing - I suggest
doing so in this CL, or at least before removing the events from WebKit, as it
seems weird to have a label that does nothing.

[xunjieli, 2015-02-18 20:30:31]

On 2015/02/18 19:00:49, mmenke wrote:
> On 2015/02/17 22:05:03, xunjieli wrote:
> > I am going to deprecate "net" category in tracing in three steps:
> > #1. Remove "net" events in chrome/src/
> > #2. Remove "net" events from third_party/WebKit/
> > #3. Remove "disable-by-default-" prefix from "netlog" category.
> > 
> > This CL is #1. Let me know if you'd like me to do #3 before #1 & #2.
> > 
> > Thanks!
> 
> You'll also want to remove the "net" section from about:tracing - I suggest
> doing so in this CL, or at least before removing the events from WebKit, as it
> seems weird to have a label that does nothing.

I have created a pull request at
https://github.com/google/trace-viewer/pull/764.
Matt, could you take a look at that when you get time?

[mmenke, 2015-02-18 20:41:16]

On 2015/02/18 20:30:31, xunjieli wrote:
> On 2015/02/18 19:00:49, mmenke wrote:
> > On 2015/02/17 22:05:03, xunjieli wrote:
> > > I am going to deprecate "net" category in tracing in three steps:
> > > #1. Remove "net" events in chrome/src/
> > > #2. Remove "net" events from third_party/WebKit/
> > > #3. Remove "disable-by-default-" prefix from "netlog" category.
> > > 
> > > This CL is #1. Let me know if you'd like me to do #3 before #1 & #2.
> > > 
> > > Thanks!
> > 
> > You'll also want to remove the "net" section from about:tracing - I suggest
> > doing so in this CL, or at least before removing the events from WebKit, as
it
> > seems weird to have a label that does nothing.
> 
> I have created a pull request at
> https://github.com/google/trace-viewer/pull/764.
> Matt, could you take a look at that when you get time?

Thanks!  Seems a bit unfortunate that we have that list in another repo.

[mmenke, 2015-02-18 20:41:26]

LGTM, modulo comment

https://codereview.chromium.org/931343002/diff/1/chrome/browser/net/chrome_ne...
File chrome/browser/net/chrome_network_delegate.cc (right):

https://codereview.chromium.org/931343002/diff/1/chrome/browser/net/chrome_ne...
chrome/browser/net/chrome_network_delegate.cc:25: #include
"base/trace_event/trace_event.h"
Is this still needed?  (Hrm...doesn't look like the other file includes it,
curiously)

[xunjieli, 2015-02-18 21:23:04]

New patchsets have been uploaded after l-g-t-m from mmenke@chromium.org

[xunjieli, 2015-02-18 21:23:29]

Thanks for the review!

https://codereview.chromium.org/931343002/diff/1/chrome/browser/net/chrome_ne...
File chrome/browser/net/chrome_network_delegate.cc (right):

https://codereview.chromium.org/931343002/diff/1/chrome/browser/net/chrome_ne...
chrome/browser/net/chrome_network_delegate.cc:25: #include
"base/trace_event/trace_event.h"
On 2015/02/18 20:41:26, mmenke wrote:
> Is this still needed?  (Hrm...doesn't look like the other file includes it,
> curiously)

Done.

[xunjieli, 2015-02-23 17:16:55]

Pinging Nat. Is it okay to land this?

[nduca, 2015-02-25 21:47:27]

lgtm when the other is landed

[xunjieli, 2015-02-26 16:23:44]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2015-02-26 16:23:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/931343002/20001

[commit-bot: I haz the power, 2015-02-26 17:18:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-26 17:19:48]

Patchset 2 (id:??) landed as
https://crrev.com/a079a1abb92e6c604eb3f73dfec62a48c8c4ec77
Cr-Commit-Position: refs/heads/master@{#318250}