Issue 931273002: Fix the tests after my previous commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 931273002: Fix the tests after my previous commit. (Closed)

Created:
5 years, 10 months ago by eseidel

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix the tests after my previous commit. This actually makes [Named] work, previously it was generating invalid dart. TBR=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/a8152043a0db3b325c1bfb2c789b39e0471ee730

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sky/engine/bindings/scripts/templates/interface_dart.template	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/engine/core/dom/shadow/ShadowRoot.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

eseidel

5 years, 10 months ago (2015-02-17 19:09:31 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a8152043a0db3b325c1bfb2c789b39e0471ee730 (presubmit successful).