Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 931263002: MIPS: [turbofan] Optimize certain chains of Branch into a Switch. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Optimize certain chains of Branch into a Switch. Port acd9c46ca7a0ada723d717f2545fd484c824eaa2 Original commit message: This adds a new ControlFlowOptimizer that - for now - recognizes chains of Branches generated by the SwitchBuilder for a subset of javascript switches into Switch nodes. Those Switch nodes are then lowered to either table or lookup switches. Also rename Case to IfValue (and introduce IfDefault) for consistency. BUG=v8:3872 LOG=n Committed: https://crrev.com/97a4a21a6acfd77bbdf2b027bfa5c459b54acbdd Cr-Commit-Position: refs/heads/master@{#26707}

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -52 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 3 chunks +36 lines, -24 lines 1 comment Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +60 lines, -0 lines 1 comment Download
M src/compiler/mips64/code-generator-mips64.cc View 3 chunks +41 lines, -28 lines 2 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +61 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-17 18:55:15 UTC) #2
paul.l...
There are some issues that need to be fixed, but I am giving this an ...
5 years, 10 months ago (2015-02-17 19:33:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931263002/1
5 years, 10 months ago (2015-02-17 20:05:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 20:44:06 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 20:44:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97a4a21a6acfd77bbdf2b027bfa5c459b54acbdd
Cr-Commit-Position: refs/heads/master@{#26707}

Powered by Google App Engine
This is Rietveld 408576698