Issue 931233003: Remove redundant helpers from JSGenericLowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 931233003: Remove redundant helpers from JSGenericLowering. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger

Modified:
5 years, 10 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove redundant helpers from JSGenericLowering. R=bmeurer@chromium.org Committed: https://crrev.com/e22c41eb0d1e601666c74d44c210aad361b4ef16 Cr-Commit-Position: refs/heads/master@{#26706}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -45 lines)			Patch
	M	src/compiler/js-generic-lowering.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	src/compiler/js-generic-lowering.cc	View		15 chunks	+33 lines, -41 lines	0 comments	Download

Total messages: 6 (1 generated)

Michael Starzinger

By now these helpers are just one-line dispatchers, since we heave the appropriate utility methods ...

5 years, 10 months ago (2015-02-17 17:33:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931233003/1

5 years, 10 months ago (2015-02-17 18:37:33 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-17 18:39:02 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e22c41eb0d1e601666c74d44c210aad361b4ef16
Cr-Commit-Position: refs/heads/master@{#26706}