Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 931223002: [strong] deprecate empty sub-statements (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Another rebase & merge conflicts #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -21 lines) Patch
M src/messages.js View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 2 10 chunks +28 lines, -9 lines 0 comments Download
M src/preparser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/preparser.cc View 1 2 9 chunks +22 lines, -8 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M test/mjsunit/strong/delete.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/strong/empty-statement.js View 1 chunk +19 lines, -0 lines 1 comment Download
M test/mjsunit/strong/equality.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/use-strong.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
rossberg
5 years, 10 months ago (2015-02-17 15:15:31 UTC) #1
marja
lgtm
5 years, 10 months ago (2015-02-17 15:29:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931223002/20001
5 years, 10 months ago (2015-02-17 15:37:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/1455) v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 10 months ago (2015-02-17 15:46:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931223002/40001
5 years, 10 months ago (2015-02-17 15:58:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/1461)
5 years, 10 months ago (2015-02-17 16:05:09 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c503241945ce25503bbf5c6e8fe506209bb7a0d9 Cr-Commit-Position: refs/heads/master@{#26701}
5 years, 10 months ago (2015-02-17 16:26:13 UTC) #12
rossberg
Committed patchset #3 (id:40001) manually as c503241945ce25503bbf5c6e8fe506209bb7a0d9 (presubmit successful).
5 years, 10 months ago (2015-02-17 16:26:16 UTC) #13
arv (Not doing code reviews)
5 years, 10 months ago (2015-02-18 19:21:33 UTC) #15
Message was sent while issue was closed. 
LGTM

https://codereview.chromium.org/931223002/diff/40001/test/mjsunit/strong/empt...
File test/mjsunit/strong/empty-statement.js (right):

https://codereview.chromium.org/931223002/diff/40001/test/mjsunit/strong/empt...
test/mjsunit/strong/empty-statement.js:18: assertThrows("'use strong'; with
({});", SyntaxError);
This error is not the error you expect it to be.

Powered by Google App Engine
This is Rietveld 408576698