Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 931183002: add gm for path-arcs, and catch degenerate arc in conic-case (Closed)

Created:
5 years, 10 months ago by reed2
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add gm for path-arcs, and catch degenerate arc in conic-case BUG=skia:3428 Committed: https://skia.googlesource.com/skia/+/9e779d495130009926fc5394a8971eec20494e5f

Patch Set 1 #

Total comments: 5

Patch Set 2 : better dox #

Patch Set 3 : add bloody 'f's after my decimal numbers #

Patch Set 4 : The C parser and warnings as just AWESOME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -5 lines) Patch
M gm/addarc.cpp View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
M include/core/SkPath.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 1 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
reed2
should fix layouttests
5 years, 10 months ago (2015-02-17 13:27:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931183002/1
5 years, 10 months ago (2015-02-17 13:27:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-17 13:27:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2504)
5 years, 10 months ago (2015-02-17 13:33:38 UTC) #7
f(malita)
lgtm % win build fix Let's also add a bug number to link this to ...
5 years, 10 months ago (2015-02-17 13:45:26 UTC) #8
robertphillips
lgtm + nits https://codereview.chromium.org/931183002/diff/1/gm/addarc.cpp File gm/addarc.cpp (right): https://codereview.chromium.org/931183002/diff/1/gm/addarc.cpp#newcode174 gm/addarc.cpp:174: Which one? https://codereview.chromium.org/931183002/diff/1/gm/addarc.cpp#newcode217 gm/addarc.cpp:217: path.moveTo(0, 2); ...
5 years, 10 months ago (2015-02-17 17:33:45 UTC) #9
reed2
On 2015/02/17 13:45:26, f(malita) wrote: > lgtm % win build fix > > Let's also ...
5 years, 10 months ago (2015-02-17 18:31:21 UTC) #10
reed2
https://codereview.chromium.org/931183002/diff/1/gm/addarc.cpp File gm/addarc.cpp (right): https://codereview.chromium.org/931183002/diff/1/gm/addarc.cpp#newcode174 gm/addarc.cpp:174: On 2015/02/17 17:33:45, robertphillips wrote: > Which one? Done. ...
5 years, 10 months ago (2015-02-17 18:35:36 UTC) #11
reed2
https://codereview.chromium.org/931183002/diff/1/gm/addarc.cpp File gm/addarc.cpp (right): https://codereview.chromium.org/931183002/diff/1/gm/addarc.cpp#newcode217 gm/addarc.cpp:217: path.moveTo(0, 2); On 2015/02/17 17:33:45, robertphillips wrote: > overlength ...
5 years, 10 months ago (2015-02-17 18:55:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931183002/20001
5 years, 10 months ago (2015-02-17 18:56:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2515)
5 years, 10 months ago (2015-02-17 19:03:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931183002/40001
5 years, 10 months ago (2015-02-17 19:08:29 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/2140)
5 years, 10 months ago (2015-02-17 19:10:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931183002/60001
5 years, 10 months ago (2015-02-17 19:16:39 UTC) #23
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 19:43:18 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9e779d495130009926fc5394a8971eec20494e5f

Powered by Google App Engine
This is Rietveld 408576698