Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 931163002: Adjust types in SourcePosition. int -> uint32_t (Closed)

Created:
5 years, 10 months ago by loislo
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne, alph, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adjust types in SourcePosition. int -> uint32_t BUG= LOG=n Committed: https://crrev.com/e22194ea2c721a1ccff4ad35515db234c196772d Cr-Commit-Position: refs/heads/master@{#26713}

Patch Set 1 #

Patch Set 2 : minor changes #

Patch Set 3 : minor changes #

Patch Set 4 : unnecessary change was removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/compiler.h View 1 2 2 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
loislo
PTAL
5 years, 10 months ago (2015-02-17 13:24:25 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-18 07:03:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931163002/30001
5 years, 10 months ago (2015-02-18 07:04:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931163002/50001
5 years, 10 months ago (2015-02-18 07:11:35 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 10 months ago (2015-02-18 07:33:26 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 07:33:47 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e22194ea2c721a1ccff4ad35515db234c196772d
Cr-Commit-Position: refs/heads/master@{#26713}

Powered by Google App Engine
This is Rietveld 408576698