Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 931153003: Add an --in switch to ipc_message_util to support minimization in CF. (Closed)

Created:
5 years, 10 months ago by Martin Barbella
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an --in switch to ipc_message_util to support minimization in CF. BUG=450268 R=inferno@chromium.org,tsepez@chromium.org Committed: https://crrev.com/66c7eff8184adfdcd58e2d381956382635b17ecf Cr-Commit-Position: refs/heads/master@{#316593}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M tools/ipc_fuzzer/mutate/message_util.cc View 7 chunks +25 lines, -1 line 3 comments Download

Messages

Total messages: 6 (1 generated)
inferno
lgtm
5 years, 10 months ago (2015-02-17 16:53:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931153003/1
5 years, 10 months ago (2015-02-17 16:53:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 17:13:05 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/66c7eff8184adfdcd58e2d381956382635b17ecf Cr-Commit-Position: refs/heads/master@{#316593}
5 years, 10 months ago (2015-02-17 17:16:10 UTC) #5
Tom Sepez
5 years, 10 months ago (2015-02-17 18:50:47 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/931153003/diff/1/tools/ipc_fuzzer/mutate/mess...
File tools/ipc_fuzzer/mutate/message_util.cc (right):

https://codereview.chromium.org/931153003/diff/1/tools/ipc_fuzzer/mutate/mess...
tools/ipc_fuzzer/mutate/message_util.cc:33: "output only the messages in the
specified list.";
nit: is this a list of message IDs or a list of ordinal positions?

https://codereview.chromium.org/931153003/diff/1/tools/ipc_fuzzer/mutate/mess...
tools/ipc_fuzzer/mutate/message_util.cc:105: bool has_indices =
cmd->HasSwitch(kInSwitch);
nit: You can move these down to line 137 or so since it doesn't look like they
are used earlier.

https://codereview.chromium.org/931153003/diff/1/tools/ipc_fuzzer/mutate/mess...
tools/ipc_fuzzer/mutate/message_util.cc:106: std::vector<bool> indices;
nit: you probably want std::set<int> here.  If I'm reading this right, and the
vector is indexed by the message id, the storage could be large due to the
sparse nature of the way we generate message IDs.  On the other hand, if the
vector is indexed by the ordinal position in the message file, this is  OK.

Powered by Google App Engine
This is Rietveld 408576698