Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 931153002: Oilpan: move the GradientStop value object off the heap. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: move the GradientStop value object off the heap. Heap allocating collections of the GradientStop part object, as introduced in r183472, is not really merited. The value object has no traceable fields and the collections of them have a stack lifetime. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190322

Patch Set 1 #

Patch Set 2 : use transition type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/core/css/CSSGradientValue.cpp View 1 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-17 12:57:36 UTC) #1
haraken
LGTM
5 years, 10 months ago (2015-02-17 13:07:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931153002/20001
5 years, 10 months ago (2015-02-17 13:14:52 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 14:38:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190322

Powered by Google App Engine
This is Rietveld 408576698