Issue 931153002: Oilpan: move the GradientStop value object off the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 931153002: Oilpan: move the GradientStop value object off the heap. (Closed)

Created:
5 years, 10 months ago by sof

Modified:
5 years, 10 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: move the GradientStop value object off the heap. Heap allocating collections of the GradientStop part object, as introduced in r183472, is not really merited. The value object has no traceable fields and the collections of them have a stack lifetime. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190322

Patch Set 1 #

Patch Set 2 : use transition type #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	Source/core/css/CSSGradientValue.cpp	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931153002/20001

5 years, 10 months ago (2015-02-17 13:14:52 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-17 14:38:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190322

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages