Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Issue 931143002: Start moving tree-boundary-crossing rules to ScopedStyleResolver. (Closed)

Created:
5 years, 10 months ago by rune
Modified:
5 years, 10 months ago
Reviewers:
hayato
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Start moving tree-boundary-crossing rules to ScopedStyleResolver. This is a step towards getting StyleResolver and the document-wide TreeBoundaryCrossingRules removed. Store tree-boundary-crossing rules on ScopedStyleResolver instead of having a map between scope and tree-boundary-crossing rules in the TreeBoundaryCrossingRules object. What's left in TreeBoundaryCrossingRules is now a list of scopes which contains tree-boundary-crossing rules. When we find an efficient way to limit the scopes considered when resolving style for a given element, we can get rid of TreeBoundaryCrossingRules completely, I think. Adding @font-face and @keyframe rules is also moved into ScopedStyleResolver and StyleResolver::processScopedRules can be removed. BUG=401359 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -135 lines) Patch
M Source/core/css/TreeBoundaryCrossingRules.h View 2 chunks +3 lines, -32 lines 0 comments Download
M Source/core/css/TreeBoundaryCrossingRules.cpp View 2 chunks +12 lines, -56 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 2 chunks +34 lines, -5 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 6 chunks +88 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 4 chunks +4 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rune
5 years, 10 months ago (2015-02-18 07:26:12 UTC) #2
hayato
Looks promising. I'll have a deeper look tomorrow.
5 years, 10 months ago (2015-02-19 08:24:10 UTC) #3
hayato
lgtm
5 years, 10 months ago (2015-02-20 07:15:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931143002/1
5 years, 10 months ago (2015-02-20 09:33:52 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 10:52:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190549

Powered by Google App Engine
This is Rietveld 408576698