Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 931123002: Files.app: Update visual style of progress center. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Update visual style of progress center. - Color the progress bar green. - Use Material Design's expand icon to open/shrink progress panel. - Show expand button slightly higher than the progress bar. (Cancel button should stay in the same level as progress bar.) BUG=402344 TEST=manually checked Committed: https://crrev.com/871c2e5bba17b4f8d6fb20f6fb4ad1b436ec801e Cr-Commit-Position: refs/heads/master@{#316577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -52 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 7 chunks +27 lines, -52 lines 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/cancel.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/2x/close_bar.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/expand_less_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/expand_more.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/2x/process_drawer_button_closed.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/2x/process_drawer_button_closed_hover.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/2x/process_drawer_button_closed_pressed.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/2x/process_drawer_button_opened.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/2x/process_drawer_button_opened_hover.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/2x/process_drawer_button_opened_pressed.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/cancel.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/close_bar.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/expand_less_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/expand_more.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/process_drawer_button_closed.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/process_drawer_button_closed_hover.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/process_drawer_button_closed_pressed.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/process_drawer_button_opened.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/process_drawer_button_opened_hover.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/files/ui/process_drawer_button_opened_pressed.png View Binary file 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
Could you take a look? Thanks!
5 years, 10 months ago (2015-02-17 11:23:10 UTC) #2
hirono
lgtm!
5 years, 10 months ago (2015-02-17 12:39:39 UTC) #3
fukino
On 2015/02/17 12:39:39, hirono wrote: > lgtm! Thanks!
5 years, 10 months ago (2015-02-17 14:32:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931123002/1
5 years, 10 months ago (2015-02-17 14:34:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 14:59:02 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 14:59:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/871c2e5bba17b4f8d6fb20f6fb4ad1b436ec801e
Cr-Commit-Position: refs/heads/master@{#316577}

Powered by Google App Engine
This is Rietveld 408576698