Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 93112: Make messages in javascript's alert copyable.... (Closed)

Created:
11 years, 8 months ago by hamaji
Modified:
9 years, 7 months ago
Reviewers:
tony, jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make messages in javascript's alert copyable. Now, we can copy the message by Ctrl-C. BUG=5879

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/browser/views/jsmessage_box_dialog.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/views/controls/message_box_view.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/views/controls/message_box_view.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hamaji
11 years, 8 months ago (2009-04-24 03:53:58 UTC) #1
tony
LGTM, but I don't know the views accelerator code that much. CC-ing jay who should ...
11 years, 8 months ago (2009-04-24 16:11:00 UTC) #2
jcampan
LGTM http://codereview.chromium.org/93112/diff/1/3 File chrome/views/controls/message_box_view.h (right): http://codereview.chromium.org/93112/diff/1/3#newcode62 Line 62: // Handles control plus 'c' and writes ...
11 years, 8 months ago (2009-04-24 16:44:42 UTC) #3
hamaji
Thanks you for the review. Tony, I don't have commit access yet. Could you check ...
11 years, 8 months ago (2009-04-24 17:03:19 UTC) #4
tony
11 years, 8 months ago (2009-04-24 17:50:40 UTC) #5
Committed in r14441.  Thanks!

Powered by Google App Engine
This is Rietveld 408576698