Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 931113003: [Push] Use proper accessors for PushMessagingApplicationId. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
Reviewers:
johnme
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Push] Use proper accessors for PushMessagingApplicationId. The current design is violating the coding style (public member variables) and is breaking some implicit functions used by some STL implementations. BUG=443228 Committed: https://crrev.com/e9c5cfd4faaac1aab890dba81c2423126eee64ee Cr-Commit-Position: refs/heads/master@{#316576}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -57 lines) Patch
M chrome/browser/services/gcm/push_messaging_application_id.h View 1 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_application_id.cc View 3 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_application_id_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_browsertest.cc View 1 2 19 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_service_impl.cc View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-17 12:32:31 UTC) #2
johnme
lgtm with nit https://codereview.chromium.org/931113003/diff/1/chrome/browser/services/gcm/push_messaging_application_id.h File chrome/browser/services/gcm/push_messaging_application_id.h (right): https://codereview.chromium.org/931113003/diff/1/chrome/browser/services/gcm/push_messaging_application_id.h#newcode73 chrome/browser/services/gcm/push_messaging_application_id.h:73: std::string app_id_guid_; I'd rather you keep ...
5 years, 10 months ago (2015-02-17 12:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931113003/20001
5 years, 10 months ago (2015-02-17 12:48:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/43364)
5 years, 10 months ago (2015-02-17 13:00:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931113003/40001
5 years, 10 months ago (2015-02-17 13:57:19 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-17 14:40:26 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 14:41:31 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e9c5cfd4faaac1aab890dba81c2423126eee64ee
Cr-Commit-Position: refs/heads/master@{#316576}

Powered by Google App Engine
This is Rietveld 408576698