Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 931103002: Add transition animation of thumbnail update in grid view. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add transition animation of thumbnail update in grid view. BUG=456016 TEST=Open a grid view and edit an image. Thumbnail should be updated with animation. Committed: https://crrev.com/2a8444b4e2c1378f64424337fa196ea3c6e3fef7 Cr-Commit-Position: refs/heads/master@{#316553}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 7 chunks +26 lines, -25 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you! https://codereview.chromium.org/931103002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_grid.js File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (left): https://codereview.chromium.org/931103002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_grid.js#oldcode21 ui/file_manager/file_manager/foreground/js/ui/file_grid.js:21: FileGrid.ThumbnailQuality = { Since this enum ...
5 years, 10 months ago (2015-02-17 09:21:25 UTC) #2
fukino
lgtm. Thanks!
5 years, 10 months ago (2015-02-17 09:49:05 UTC) #3
yawano
On 2015/02/17 09:49:05, fukino wrote: > lgtm. Thanks! Thank you!
5 years, 10 months ago (2015-02-17 09:49:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931103002/1
5 years, 10 months ago (2015-02-17 09:50:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 10:14:59 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 10:15:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a8444b4e2c1378f64424337fa196ea3c6e3fef7
Cr-Commit-Position: refs/heads/master@{#316553}

Powered by Google App Engine
This is Rietveld 408576698