Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 931083002: Implement most common usecase for elements kind generalization (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement most common usecase for elements kind generalization BUG= Committed: https://crrev.com/8e53e31eeb2281038ab27542c5593d2e845aa594 Cr-Commit-Position: refs/heads/master@{#26681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M src/objects.cc View 5 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL This handles the case were named properties are added to JSArrays.
5 years, 10 months ago (2015-02-17 07:50:22 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-02-17 09:43:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931083002/1
5 years, 10 months ago (2015-02-17 09:46:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 10:06:56 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 10:07:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e53e31eeb2281038ab27542c5593d2e845aa594
Cr-Commit-Position: refs/heads/master@{#26681}

Powered by Google App Engine
This is Rietveld 408576698