Fix for Incomplete context menu shown in PDF.

Fix for Incomplete context menu shown in pdf as
reload,back,forward options are missing in context menu.

when we have MimeHandlerViewGuest then we should use embedded webcontent and should show full page context menu.

Changes done for using embedded web contents when we have guest view and showing full page context menu.

BUG=449919
Committed: https://crrev.com/6d3e1fd0bcb68f3e0f26119b783945e31e104528
Cr-Commit-Position: refs/heads/master@{#316843}

[Deepak, 2015-02-17 08:32:01]

deepak.m1@samsung.com changed reviewers:
+ avi@chromium.org, lazyboy@chromium.org, raymes@chromium.org,
sammc@chromium.org

[Deepak, 2015-02-17 08:32:01]

PTAL.
Thanks

[Avi (use Gerrit), 2015-02-17 16:22:42]

https://codereview.chromium.org/931073002/diff/1/chrome/browser/renderer_cont...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/931073002/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1012: return
GetWebContentsToUse(source_web_contents_)
Can you pull GetWebContentsToUse(source_web_contents_) into a variable?

[raymes, 2015-02-18 00:39:46]

Note that rotate commands aren't working in the embedded case.

https://codereview.chromium.org/931073002/diff/1/chrome/browser/renderer_cont...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/931073002/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:775: if
(params_.link_url.is_empty() && params_.selection_text.empty())
As mentioned on my comment in the previous CL - I would like to revert this part
of the change as well and follow the full-page case when it is a MimeHandlerView

[Deepak, 2015-02-18 05:51:34]

@Avi
Thanks for review.
Changes done as suggested.
PTAL.

[Avi (use Gerrit), 2015-02-18 15:25:44]

lgtm

ok.

[Deepak, 2015-02-18 16:37:58]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-02-18 16:38:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/931073002/20001

[commit-bot: I haz the power, 2015-02-18 16:42:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-18 16:42:53]

Patchset 2 (id:??) landed as
https://crrev.com/6d3e1fd0bcb68f3e0f26119b783945e31e104528
Cr-Commit-Position: refs/heads/master@{#316843}

[raymes, 2015-02-19 00:20:46]

Hey Deepak. Please make this change in a followup CL. Also, note that the Rotate
menu items don't work in the embedded case. Could you please look into that?
Thanks!

https://codereview.chromium.org/931073002/diff/20001/components/renderer_cont...
File components/renderer_context_menu/render_view_context_menu_base.h (right):

https://codereview.chromium.org/931073002/diff/20001/components/renderer_cont...
components/renderer_context_menu/render_view_context_menu_base.h:166:
content::WebContents* embedded_web_contents_;
This should be called embedder_web_contents_.

Please also add a comment.

// In the case of a MimeHandlerView this will point to the WebContents that
embeds the MimeHandlerViewGuest. Otherwise this will be the same as
source_web_contents_.

[Deepak, 2015-02-19 03:34:52]

On 2015/02/19 00:20:46, raymes wrote:
> Hey Deepak. Please make this change in a followup CL. Also, note that the
Rotate
> menu items don't work in the embedded case. Could you please look into that?
> Thanks!
> 
>
https://codereview.chromium.org/931073002/diff/20001/components/renderer_cont...
> File components/renderer_context_menu/render_view_context_menu_base.h (right):
> 
>
https://codereview.chromium.org/931073002/diff/20001/components/renderer_cont...
> components/renderer_context_menu/render_view_context_menu_base.h:166:
> content::WebContents* embedded_web_contents_;
> This should be called embedder_web_contents_.
> 
> Please also add a comment.
> 
> // In the case of a MimeHandlerView this will point to the WebContents that
> embeds the MimeHandlerViewGuest. Otherwise this will be the same as
> source_web_contents_.

ya, sure I will do this ASAP.
Thanks.