Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 931033002: <webview>-based Signin Page: Navigate on Drag and Drop (Closed)

Created:
5 years, 10 months ago by Fady Samuel
Modified:
5 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview>-based Signin Page: Navigate on Drag and Drop Listen to the drop handler, check if it's a URL, and navigate the tab if so. BUG=449912 TBR=xiyuan@chromium.org Committed: https://crrev.com/124618917b61d243e424bc74d34b27a69ef57ca3 Cr-Commit-Position: refs/heads/master@{#316600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/resources/gaia_auth_host/authenticator.js View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/inline_login/inline_login.js View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Fady Samuel
5 years, 10 months ago (2015-02-17 02:58:50 UTC) #2
Fady Samuel
5 years, 10 months ago (2015-02-17 02:59:03 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm
5 years, 10 months ago (2015-02-17 16:51:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931033002/1
5 years, 10 months ago (2015-02-17 16:54:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 17:44:18 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 17:45:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/124618917b61d243e424bc74d34b27a69ef57ca3
Cr-Commit-Position: refs/heads/master@{#316600}

Powered by Google App Engine
This is Rietveld 408576698