Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: commit-queue/buildbot_json.py

Issue 93103002: CQ: print buildbot URL it's trying to access on errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit-queue/buildbot_json.py
===================================================================
--- commit-queue/buildbot_json.py (revision 237637)
+++ commit-queue/buildbot_json.py (working copy)
@@ -946,9 +946,14 @@
else:
url += '?filter=1'
logging.debug('read(%s)' % suburl)
- channel = urllib.urlopen(url)
- data = channel.read()
try:
+ channel = urllib.urlopen(url)
+ data = channel.read()
+ except IOError as e:
+ logging.warning('caught %s while fetching "%s"; re-throwing' % (
+ str(e), url))
+ raise
+ try:
return json.loads(data)
except ValueError:
if channel.getcode() >= 400:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698