OOP PDF: Fix incorrect scrolling during fit-to-page

OOP PDF: Fix incorrect scrolling during fit-to-page

Currently whenever fitToPage is called on the viewport, it scrolls to
the top of the current page. But this isn't always correct. In the
case of resizing the viewport, we shouldn't change the scroll pos.
Setting the document dimensions also follows this codepath.

BUG=458050
Committed: https://crrev.com/161514f59647a9462af1d98652fb85d8c1bd6002
Cr-Commit-Position: refs/heads/master@{#316531}

[raymes, 2015-02-17 00:08:53]

raymes@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2015-02-17 03:42:21]

https://codereview.chromium.org/931013002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/viewport.js (right):

https://codereview.chromium.org/931013002/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/viewport.js:416: fitToPageAndScroll_:
function(scrollToTopOfPage) {
This name suggests that it will always scroll somewhere.

https://codereview.chromium.org/931013002/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/viewport.js:433: this.window_.scrollTo(0, oldY *
this.zoom_);
Shouldn't setZoomInternal_ do this?

[raymes, 2015-02-17 03:51:57]

https://codereview.chromium.org/931013002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/viewport.js (right):

https://codereview.chromium.org/931013002/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/viewport.js:416: fitToPageAndScroll_:
function(scrollToTopOfPage) {
On 2015/02/17 03:42:21, Sam McNally wrote:
> This name suggests that it will always scroll somewhere.

Done.

https://codereview.chromium.org/931013002/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/viewport.js:433: this.window_.scrollTo(0, oldY *
this.zoom_);
On 2015/02/17 03:42:21, Sam McNally wrote:
> Shouldn't setZoomInternal_ do this?

I guess the only difference is we want to scroll to 0 x-offset. I made this
change.

[Sam McNally, 2015-02-17 04:11:13]

lgtm

[raymes, 2015-02-17 04:12:52]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2015-02-17 04:13:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/931013002/60001

[commit-bot: I haz the power, 2015-02-17 05:09:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-17 05:11:03]

Patchset 4 (id:??) landed as
https://crrev.com/161514f59647a9462af1d98652fb85d8c1bd6002
Cr-Commit-Position: refs/heads/master@{#316531}