Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Issue 9310050: [cros] Error bubble on login is displayed to the left of Gaia frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: License fixes. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.js
diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
index e80727f9a71b40a24d88e241be699ae88d2a7774..8cf14a89e79822721c93c3bb8e0d0867cd108570 100644
--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
@@ -269,6 +269,11 @@ cr.define('login', function() {
}
$('error-message').update();
this.loading = false;
+ // Show deferred error bubble.
+ if (this.errorBubble_) {
+ this.showErrorBubble(this.errorBubble_[0], this.errorBubble_[1]);
+ this.errorBubble_ = undefined;
+ }
this.clearRetry_();
chrome.send('loginWebuiReady');
} else if (msg.method =='offlineLogin' && this.isAuthExtMessage_(e)) {
@@ -369,6 +374,27 @@ cr.define('login', function() {
$('guestSigninLink').onclick = function() {
chrome.send('launchIncognito');
};
+ },
+
+ /**
+ * Shows sign-in error bubble.
+ * @param {number} loginAttempts Number of login attemps tried.
+ * @param {HTMLElement} content Content to show in bubble.
+ */
+ showErrorBubble: function(loginAttempts, error) {
+ if (this.isLocal) {
+ $('add-user-button').hidden = true;
+ $('cancel-add-user-button').hidden = false;
+ // Reload offline version of the sign-in extension, which will show
+ // error itself.
+ chrome.send('offlineLogin', [this.email]);
+ } else if (!this.loading) {
+ $('bubble').showContentForElement($('login-box'), error,
+ cr.ui.Bubble.Attachment.LEFT);
+ } else {
+ // Defer the bubble until the frame has been loaded.
+ this.errorBubble_ = [loginAttempts, error];
+ }
}
};

Powered by Google App Engine
This is Rietveld 408576698