Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 93099: Merge 13773 - For some Indian locales, the automatic font fallback by Windows... (Closed)

Created:
11 years, 8 months ago by laforge
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/
Visibility:
Public.

Description

Merge 13773 - For some Indian locales, the automatic font fallback by Windows UI components leads to too tiny glyphs for UI strings. Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER percentile scale). It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch). For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used. For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150. When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY. While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner. The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac. TEST=1. Run chrome with 'lang=bn' or 'lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With 'lang=hi' and 'lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same. 2.UI test in enUS locale should pass. 3. Running UI tests under Purify should not have any new leak. BUG=7319 Review URL: http://codereview.chromium.org/62064 TBR=jungshik@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -53 lines) Patch
MM chrome/app/resources/locale_settings.grd View 2 chunks +22 lines, -1 line 0 comments Download
MM chrome/app/resources/locale_settings_ar.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_bg.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_bn.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_ca.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_cs.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_da.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_de.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_el.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_en-GB.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_es.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_es-419.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_et.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_fi.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_fil.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_fr.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_gu.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_he.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_hi.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_hr.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_hu.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_id.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_it.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_ja.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_kn.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_ko.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_lt.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_lv.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_ml.xtb View 2 chunks +3 lines, -1 line 0 comments Download
MM chrome/app/resources/locale_settings_mr.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_nb.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_nl.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_or.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_pl.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_pt-BR.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_pt-PT.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_ro.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_ru.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_sk.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_sl.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_sr.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_sv.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_ta.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_te.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_th.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_tr.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_uk.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_vi.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_zh-CN.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/app/resources/locale_settings_zh-TW.xtb View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/browser/views/constrained_window_impl.cc View 5 chunks +7 lines, -7 lines 0 comments Download
MM chrome/browser/views/frame/opaque_browser_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/views/frame/opaque_browser_frame_view.cc View 6 chunks +7 lines, -6 lines 0 comments Download
MM chrome/browser/views/sad_tab_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/views/sad_tab_view.cc View 4 chunks +11 lines, -10 lines 0 comments Download
MM chrome/browser/views/tabs/tab_renderer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
MM chrome/common/gfx/chrome_font_win.cc View 2 chunks +6 lines, -1 line 0 comments Download
MM chrome/common/l10n_util_win.h View 1 chunk +20 lines, -0 lines 0 comments Download
MM chrome/common/l10n_util_win.cc View 2 chunks +68 lines, -0 lines 0 comments Download
MM chrome/common/win_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download
MM chrome/views/controls/menu/chrome_menu.cc View 2 chunks +2 lines, -0 lines 0 comments Download
MM chrome/views/controls/menu/menu.cc View 5 chunks +31 lines, -6 lines 0 comments Download
MM chrome/views/controls/table/table_view.cc View 3 chunks +3 lines, -0 lines 0 comments Download
MM chrome/views/controls/tree/tree_view.cc View 2 chunks +3 lines, -0 lines 0 comments Download
MM chrome/views/widget/aero_tooltip_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
MM chrome/views/widget/tooltip_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
MM chrome/views/widget/tooltip_manager.cc View 3 chunks +4 lines, -2 lines 0 comments Download
MM chrome/views/window/custom_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/views/window/custom_frame_view.cc View 6 chunks +6 lines, -7 lines 0 comments Download
MM chrome/views/window/dialog_client_view.h View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/views/window/dialog_client_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 8 months ago (2009-04-23 23:37:11 UTC) #1
jungshik at Google
11 years, 8 months ago (2009-04-24 00:05:08 UTC) #2
thank you for merging this to the branch.

Powered by Google App Engine
This is Rietveld 408576698