Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: src/objects.cc

Issue 930983003: Reduce field type tracking to a single stable map per field. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 775a66479bff7cd527592cacadfb79f491610a47..74f8d52bda5739f2de5682b113b7beaeb198fcf4 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2326,18 +2326,8 @@ void Map::UpdateFieldType(int descriptor, Handle<Name> name,
Handle<HeapType> Map::GeneralizeFieldType(Handle<HeapType> type1,
Handle<HeapType> type2,
Isolate* isolate) {
- static const int kMaxClassesPerFieldType = 5;
if (type1->NowIs(type2)) return type2;
if (type2->NowIs(type1)) return type1;
- if (type1->NowStable() && type2->NowStable()) {
- Handle<HeapType> type = HeapType::Union(type1, type2, isolate);
- if (type->NumClasses() <= kMaxClassesPerFieldType) {
- DCHECK(type->NowStable());
- DCHECK(type1->NowIs(type));
- DCHECK(type2->NowIs(type));
- return type;
- }
- }
return HeapType::Any(isolate);
}
« no previous file with comments | « no previous file | src/types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698