Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 930933005: Files.app: Remove height limitation from rename input of grid item. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Remove height limitation from rename input of grid item. BUG=454938 TEST=check repro steps described on the issue. Committed: https://crrev.com/07064b0ef19984fca2655ebc16f6d342fa93859e Cr-Commit-Position: refs/heads/master@{#317284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
PTAL. Thanks!
5 years, 10 months ago (2015-02-20 10:35:54 UTC) #2
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-20 10:41:27 UTC) #3
fukino
Thank you for quick review(s)!
5 years, 10 months ago (2015-02-20 10:42:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930933005/1
5 years, 10 months ago (2015-02-20 10:44:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 11:08:23 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 11:09:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07064b0ef19984fca2655ebc16f6d342fa93859e
Cr-Commit-Position: refs/heads/master@{#317284}

Powered by Google App Engine
This is Rietveld 408576698