Add GN targets for codesighs and telemetry

Add GN targets for codesighs and telemetry.

This also adds app_shell_unittests to the :root target.

BUG=None

Committed: https://crrev.com/2f1326e6b56aba18307317bf936668309cd18705
Cr-Commit-Position: refs/heads/master@{#317680}

[Ken Rockot(use gerrit already), 2015-02-17 21:04:23]

rockot@chromium.org changed reviewers:
+ dpranke@chromium.org, dtu@chromium.org

[Ken Rockot(use gerrit already), 2015-02-17 21:04:23]

Dirk, here's some low-hanging fruit. Please take a look for general GN changes.

Dave please take a look for telemetry. The void casts are to suppress unused
result errors without extra flags.

[Dirk Pranke, 2015-02-17 21:22:53]

lgtm w/ change, below.

https://codereview.chromium.org/930933003/diff/60001/third_party/codesighs/BU...
File third_party/codesighs/BUILD.gn (right):

https://codereview.chromium.org/930933003/diff/60001/third_party/codesighs/BU...
third_party/codesighs/BUILD.gn:5: import("//build/config/features.gni")
I suggest we use:

    configs -= [ "//build/config/compiler:chromium_code" ]                      
    configs += [ "//build/config/compiler:no_chromium_code" ]                   

at the top-level instead of individually disabling /wd4267. It will turn off a
few other warnings, but is perhaps semantically clearer.

[Dirk Pranke, 2015-02-17 21:23:41]

Oh, and you should update the description to mention that you're adding
app_shell_unittests to the //:root target, too.

[Ken Rockot(use gerrit already), 2015-02-17 21:43:46]

New patchsets have been uploaded after l-g-t-m from dpranke@chromium.org

[Ken Rockot(use gerrit already), 2015-02-19 02:06:39]

Friendly ping for dtu@

[Ken Rockot(use gerrit already), 2015-02-20 23:00:20]

ping?

[Ken Rockot(use gerrit already), 2015-02-23 17:49:50]

rockot@chromium.org changed reviewers:
+ tonyg@chromium.org

[Ken Rockot(use gerrit already), 2015-02-23 17:49:51]

+tonyg, please take a look as a telemetry owner

[tonyg, 2015-02-23 17:55:20]

lgtm

[Ken Rockot(use gerrit already), 2015-02-23 18:36:42]

New patchsets have been uploaded after l-g-t-m from tonyg@chromium.org

[Ken Rockot(use gerrit already), 2015-02-23 21:05:12]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-02-23 21:05:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930933003/100001

[commit-bot: I haz the power, 2015-02-23 21:25:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 21:25:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2015-02-23 21:33:36]

rockot@chromium.org changed reviewers:
+ cpu@chromium.org

[Ken Rockot(use gerrit already), 2015-02-23 21:33:37]

Doh. +cpu - please review changes to codesighs GN as toplevel owner.

[cpu_(ooo_6.6-7.5), 2015-02-23 23:17:50]

lgtm

[Ken Rockot(use gerrit already), 2015-02-23 23:29:54]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:30:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930933003/100001

[commit-bot: I haz the power, 2015-02-23 23:54:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-23 23:54:39]

Patchset 6 (id:??) landed as
https://crrev.com/2f1326e6b56aba18307317bf936668309cd18705
Cr-Commit-Position: refs/heads/master@{#317680}

[binjin, 2015-02-24 00:25:34]

binjin@chromium.org changed reviewers:
+ binjin@chromium.org

[binjin, 2015-02-24 00:25:35]

This CL seems to break multiple GN build bots:


ERROR at //third_party/codesighs/BUILD.gn:31:5: Undefined variable for +=.
    libs += [ "dbghelp.lib" ]
    ^---
I don't have something with this name in scope now.

[Dirk Pranke, 2015-02-24 00:42:52]

On 2015/02/24 00:25:35, binjin wrote:
> This CL seems to break multiple GN build bots:
> 
> 
> ERROR at //third_party/codesighs/BUILD.gn:31:5: Undefined variable for +=.
>     libs += [ "dbghelp.lib" ]
>     ^---
> I don't have something with this name in scope now.

Yes, I had sent https://codereview.chromium.org/950043003/ through the CQ, but
I'm landing it directly now.

I messaged you about this on #chromium.