Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 930933002: Use TypeChecking=Unrestricted on Internal* interfaces (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
pdr., philipj_slow
CC:
arv+blink, blink-reviews, Inactive, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use TypeChecking=Unrestricted on Internal* interfaces These interfaces should generally not be used for testing the types of IDL edge-cases that non-finite numbers imply, so make all float/double parameters 'restricted'. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/build/scripts/templates/InternalSettingsGenerated.idl.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
This could really go either way - strict or non-strict - I couldn't think of ...
5 years, 10 months ago (2015-02-16 17:35:58 UTC) #2
fs
Philip^2
5 years, 10 months ago (2015-02-17 15:45:59 UTC) #4
pdr.
LGTM
5 years, 10 months ago (2015-02-17 22:29:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930933002/1
5 years, 10 months ago (2015-02-17 22:29:47 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:38:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190358

Powered by Google App Engine
This is Rietveld 408576698