Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 930923002: Add parameter to set source directories in repack locale. (Closed)

Created:
5 years, 10 months ago by Olivier
Modified:
5 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add parameter to set source directories in repack locale. This allow to pass different values for the shared and output directories. The value of the parameter is put in the same string as the parameter switch as putting them in separated string results in the deletion of the parameter value. Committed: https://crrev.com/7ddc6d4903f0ea4259a2c2a79890d3ebc07c1283 Cr-Commit-Position: refs/heads/master@{#316494}

Patch Set 1 #

Patch Set 2 : restore /. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/chrome_repack_locales.gypi View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Olivier
5 years, 10 months ago (2015-02-16 16:41:24 UTC) #2
sdefresne
lgtm
5 years, 10 months ago (2015-02-16 16:44:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930923002/20001
5 years, 10 months ago (2015-02-16 16:47:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-16 17:34:14 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 17:37:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ddc6d4903f0ea4259a2c2a79890d3ebc07c1283
Cr-Commit-Position: refs/heads/master@{#316494}

Powered by Google App Engine
This is Rietveld 408576698