Remove initial empty setting of base color for OmniBoxViewViews

Remove initial empty setting of base color for OmniBoxViewViews

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121778

[DaveMoore, 2012-02-05 22:07:07]

This was resulting in a warning message on every browser_test, cluttering up the
logs.

[oshima, 2012-02-06 17:02:52]

http://codereview.chromium.org/9309111/diff/1/chrome/browser/ui/views/omnibox...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

http://codereview.chromium.org/9309111/diff/1/chrome/browser/ui/views/omnibox...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:230: }
I looks like the color selection scheme has changed since this was added and
this is no longer necessary. (It uses LocationBarView::GetColor now) Can you
removed this and Observe (and related code)?

[DaveMoore, 2012-02-06 18:57:36]

https://chromiumcodereview.appspot.com/9309111/diff/1/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

https://chromiumcodereview.appspot.com/9309111/diff/1/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:230: }
On 2012/02/06 17:02:52, oshima wrote:
> I looks like the color selection scheme has changed since this was added and
> this is no longer necessary. (It uses LocationBarView::GetColor now) Can you
> removed this and Observe (and related code)?

Done.

[oshima, 2012-02-06 19:10:46]

LGTM with one nit

http://codereview.chromium.org/9309111/diff/5001/chrome/browser/ui/views/omni...
File chrome/browser/ui/views/omnibox/omnibox_view_views.h (right):

http://codereview.chromium.org/9309111/diff/5001/chrome/browser/ui/views/omni...
chrome/browser/ui/views/omnibox/omnibox_view_views.h:16: #include
"content/public/browser/notification_observer.h"
this is probably not necessary.

[commit-bot: I haz the power, 2012-02-06 21:59:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/9309111/9001

[commit-bot: I haz the power, 2012-02-06 21:59:59]

Presubmit check for 9309111-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/views/omnibox/omnibox_view_views.h,chrome/browser/ui/views/omnibox/omnibox_view_views.cc

[DaveMoore, 2012-02-07 00:43:51]

OWNER review please

[sky, 2012-02-07 00:49:18]

https://chromiumcodereview.appspot.com/9309111/diff/9001/chrome/browser/ui/vi...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (left):

https://chromiumcodereview.appspot.com/9309111/diff/9001/chrome/browser/ui/vi...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:674: DCHECK(type ==
chrome::NOTIFICATION_BROWSER_THEME_CHANGED);
Don't we support theme changes on chromeos?

[oshima, 2012-02-07 00:58:10]

https://chromiumcodereview.appspot.com/9309111/diff/9001/chrome/browser/ui/vi...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (left):

https://chromiumcodereview.appspot.com/9309111/diff/9001/chrome/browser/ui/vi...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:674: DCHECK(type ==
chrome::NOTIFICATION_BROWSER_THEME_CHANGED);
On 2012/02/07 00:49:18, sky wrote:
> Don't we support theme changes on chromeos?

The way to retrieve color for omnibox has chagned and it's now done through
LocationBarView::GetColor. It still have TODO(beng) for !win there, so I expect
this is not functional yet though.

[sky, 2012-02-07 01:09:50]

LGTM

[commit-bot: I haz the power, 2012-02-13 22:42:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/9309111/9001

[commit-bot: I haz the power, 2012-02-14 00:22:10]

Change committed as 121778