Switch skydb to services/http_server.

Switch skydb to services/http_server.

This patch makes the skydb debugger use the Mojo http_server app instead
of the /net http_server.

BUG=456128
R=eseidel@chromium.org, qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/8b9a0b87a06d3baccbd323b5731f26f87f15c6b1

[ppi, 2015-02-16 15:13:31]

ppi@chromium.org changed reviewers:
+ qsr@chromium.org

[ppi, 2015-02-16 15:13:32]

Hi Ben,

this should be ready for a first pass.

FYI, "skydb load URL" doesn't work with this change, but it might be a bug in
http_server handling of POST requests. I'm looking into it.

[qsr, 2015-02-17 10:33:18]

https://codereview.chromium.org/930903002/diff/40001/sky/tools/debugger/debug...
File sky/tools/debugger/debugger.cc (right):

https://codereview.chromium.org/930903002/diff/40001/sky/tools/debugger/debug...
sky/tools/debugger/debugger.cc:35: HttpResponseCallback;
This typedef is already defined for you in the generated code.

https://codereview.chromium.org/930903002/diff/40001/sky/tools/debugger/debug...
sky/tools/debugger/debugger.cc:36: class Handler : public
http_server::HttpHandler {
You can probably get rid of this class by having SkyDebuffer implements
ttp_server::HttpHandler

[ppi, 2015-02-17 12:05:25]

Thanks, Ben, ptal.

https://codereview.chromium.org/930903002/diff/40001/sky/tools/debugger/debug...
File sky/tools/debugger/debugger.cc (right):

https://codereview.chromium.org/930903002/diff/40001/sky/tools/debugger/debug...
sky/tools/debugger/debugger.cc:35: HttpResponseCallback;
On 2015/02/17 10:33:18, qsr wrote:
> This typedef is already defined for you in the generated code.

Done.

https://codereview.chromium.org/930903002/diff/40001/sky/tools/debugger/debug...
sky/tools/debugger/debugger.cc:36: class Handler : public
http_server::HttpHandler {
On 2015/02/17 10:33:18, qsr wrote:
> You can probably get rid of this class by having SkyDebuffer implements
> ttp_server::HttpHandler

Done.

[qsr, 2015-02-17 13:26:36]

LGTM with nit

https://codereview.chromium.org/930903002/diff/60001/sky/tools/debugger/debug...
File sky/tools/debugger/debugger.cc (right):

https://codereview.chromium.org/930903002/diff/60001/sky/tools/debugger/debug...
sky/tools/debugger/debugger.cc:16: #include
"mojo/public/cpp/bindings/strong_binding.h"
You do not seem to be using a strong binding, do you want to include binding.h
instead?

[ppi, 2015-02-17 13:32:45]

New patchsets have been uploaded after l-g-t-m from qsr@chromium.org

[ppi, 2015-02-17 13:34:45]

ppi@chromium.org changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org

[ppi, 2015-02-17 13:36:02]

Thanks, Ben!

Adam or Eric - ptal.

https://codereview.chromium.org/930903002/diff/60001/sky/tools/debugger/debug...
File sky/tools/debugger/debugger.cc (right):

https://codereview.chromium.org/930903002/diff/60001/sky/tools/debugger/debug...
sky/tools/debugger/debugger.cc:16: #include
"mojo/public/cpp/bindings/strong_binding.h"
On 2015/02/17 13:26:36, qsr wrote:
> You do not seem to be using a strong binding, do you want to include binding.h
> instead?

Done.

[eseidel, 2015-02-17 15:38:54]

lgtm

[ppi, 2015-02-17 16:10:32]

Committed patchset #5 (id:80001) manually as
8b9a0b87a06d3baccbd323b5731f26f87f15c6b1 (presubmit successful).