Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 930803002: Add test case for mouseleave events within window bounds (Closed)

Created:
5 years, 10 months ago by Miyoung Shin(g)
Modified:
5 years, 9 months ago
Reviewers:
Rick Byers
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add test case for mouseleave events within window bounds The test checks if the mouseout/mouseleave events are dispatched to JS when the mouse leave event is triggered within the bounds of the target window (eg. the window is being covered by some other window). BUG=450631 R=rbyers@chromium.org TEST=fast/events/event-sender-mouseleave.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191806

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
A LayoutTests/fast/events/event-sender-mouseleave.html View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/event-sender-mouseleave-expected.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Miyoung Shin(g)
This patch depends on http://crrev.com/928973002/.
5 years, 10 months ago (2015-02-16 07:44:33 UTC) #1
Miyoung Shin(g)
@Rick, PTAL. We can go the review step due to landing https://crrev.com/928973002/
5 years, 9 months ago (2015-03-06 07:35:01 UTC) #2
Rick Byers
Thanks, looks good. Just one suggestion to make it more clear what special case you're ...
5 years, 9 months ago (2015-03-06 16:05:37 UTC) #3
Miyoung Shin(g)
https://codereview.chromium.org/930803002/diff/20001/LayoutTests/fast/events/event-sender-mouseleave.html File LayoutTests/fast/events/event-sender-mouseleave.html (right): https://codereview.chromium.org/930803002/diff/20001/LayoutTests/fast/events/event-sender-mouseleave.html#newcode20 LayoutTests/fast/events/event-sender-mouseleave.html:20: description('Test that a mouse leave event is triggered.'); On ...
5 years, 9 months ago (2015-03-09 15:47:27 UTC) #4
Rick Byers
Thanks LGTM
5 years, 9 months ago (2015-03-12 16:49:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930803002/40001
5 years, 9 months ago (2015-03-13 00:05:27 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 01:32:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191806

Powered by Google App Engine
This is Rietveld 408576698