Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 930793002: Merge 190021 "Web SQL: Termiante database thread before finalizi..." (Closed)

Created:
5 years, 10 months ago by tkent
Modified:
5 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Merge 190021 "Web SQL: Termiante database thread before finalizi..." > Web SQL: Termiante database thread before finalizing the Oilpan heap for the Blink main thread. > > Oilpan heap for the database thread should be finalized before finalizing the > main thread heap. Usually it's done in ExecutionContext::stopActiveDOMObjects(). > When blink::shutdown() is called, stopActiveDOMObjects() was not called and > objects owned by the main thread is finalized though they were referred by the > database thread. blink::shutdown() should terminate the database thread > explicitly. > > BUG=455368, 455789 > > Review URL: https://codereview.chromium.org/892343003 TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M Source/modules/InitModules.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/InitModules.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 chunk +15 lines, -2 lines 0 comments Download
M Source/web/WebKit.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
5 years, 10 months ago (2015-02-16 07:00:52 UTC) #1
tkent
5 years, 10 months ago (2015-02-16 07:01:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r190225.

Powered by Google App Engine
This is Rietveld 408576698