Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 930753002: Sort GYP and GN files under ppapi (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sort GYP and GN files under ppapi For tools/sort_sources.py to be useful, existing GYP and GN files should be sorted. BUG=456014 TEST=everything should build as before Committed: https://crrev.com/c96d5d2b62b03bae7a3812b441d1470755f7a376 Cr-Commit-Position: refs/heads/master@{#316434}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -48 lines) Patch
M ppapi/examples/video_decode/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_shared.gypi View 1 10 chunks +19 lines, -18 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/shared_impl/BUILD.gn View 4 chunks +7 lines, -7 lines 0 comments Download
M ppapi/tests/extensions/extensions.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/BUILD.gn View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
satorux1
5 years, 10 months ago (2015-02-16 06:12:32 UTC) #2
raymes
lgtm
5 years, 10 months ago (2015-02-16 06:16:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930753002/20001
5 years, 10 months ago (2015-02-16 06:45:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-16 07:09:48 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 07:10:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c96d5d2b62b03bae7a3812b441d1470755f7a376
Cr-Commit-Position: refs/heads/master@{#316434}

Powered by Google App Engine
This is Rietveld 408576698