src/assembler.cpp - Issue 930733002: Subzero: Add sandboxing for x86-32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler.cpp

Issue 930733002: Subzero: Add sandboxing for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix asm emission for %gs:0 . (Was just emitting "gs:".) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/assembler.cpp

diff --git a/src/assembler.cpp b/src/assembler.cpp

index b0ff4194985d6be4ee1c941446226fb670ce3fc4..d131426d30c1ba598819dd6c1831179eb3496177 100644

--- a/src/assembler.cpp

+++ b/src/assembler.cpp

@@ -40,7 +40,8 @@ AssemblerFixup *AssemblerBuffer::createFixup(FixupKind Kind,

F->set_position(0);

F->set_kind(Kind);

F->set_value(Value);

- fixups_.push_back(F);

+ if (!assembler_.getPreliminary())

+ fixups_.push_back(F);

return F;

}

« src/assembler.h ('K') | « src/assembler.h ('k') | src/assembler_ia32.h » ('j') | no next file with comments »