src/IceCfg.cpp - Issue 930733002: Subzero: Add sandboxing for x86-32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 930733002: Subzero: Add sandboxing for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix asm emission for %gs:0 . (Was just emitting "gs:".) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index bae6c7752942bccf939a7ecaf7edce19355fe0de..77c0aa59f173a33c23f5956d0bf5a39ba8bf67d0 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -436,6 +436,7 @@ void Cfg::emitTextHeader(const IceString &MangledName, GlobalContext *Ctx,

for (uint8_t I : Asm->getNonExecBundlePadding())

Str.write_hex(I);

Str << "\n";

+ Str << "\t.bundle_align_mode " << Asm->getBundleAlignLog2Bytes() << "\n";

jvoung (off chromium) 2015/02/19 21:01:47 Should this only be for getUseSandboxing()?

Jim Stichnoth 2015/02/19 23:17:38 Oops, done.

Str << MangledName << ":\n";

}

« no previous file with comments | « no previous file | src/IceCfgNode.cpp » ('j') | src/IceCfgNode.cpp » ('J')