Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 930673002: Add an implementation of url_loader.mojom using OkHttp (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
eseidel, esprehn, mojo-reviews_chromium.org, ojan, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add an implementation of url_loader.mojom using OkHttp This CL is the beginnings of an implementation of url_loader.mojom using the OkHttp library. OkHttp is a relatively simple HTTP client library for Android that implements HTTP/1.1 and HTTP/2.0. We might want to use OkHttp to bootstrap into a more full-featured network_service implementation based on //net. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9c85fe573cb9eeaecf850f9ed6b26fb89caa8c12

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated #

Total comments: 2

Patch Set 3 : update copyright #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -0 lines) Patch
A sky/services/oknet/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java View 1 2 1 chunk +196 lines, -0 lines 1 comment Download
M sky/shell/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/apk/src/org/domokit/sky/shell/JavaServiceProvider.java View 1 2 chunks +6 lines, -0 lines 0 comments Download
A third_party/okhttp/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/okhttp/LICENSE View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/okhttp/okhttp-2.2.0.jar View Binary file 0 comments Download
A third_party/okhttp/okio-1.2.0.jar View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-15 09:27:44 UTC) #1
jamesr
If I wanted to actually check the implementation, where would I find the docs for ...
5 years, 10 months ago (2015-02-18 22:46:10 UTC) #2
abarth-chromium
On 2015/02/18 at 22:46:10, jamesr wrote: > If I wanted to actually check the implementation, ...
5 years, 10 months ago (2015-02-18 22:56:43 UTC) #3
abarth-chromium
https://codereview.chromium.org/930673002/diff/20001/sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java File sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java (right): https://codereview.chromium.org/930673002/diff/20001/sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java#newcode48 sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java:48: cookieStore.close(); On 2015/02/18 at 22:46:10, jamesr wrote: > is ...
5 years, 10 months ago (2015-02-18 22:58:09 UTC) #4
jamesr
lgtm https://codereview.chromium.org/930673002/diff/40001/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java File sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java (right): https://codereview.chromium.org/930673002/diff/40001/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java#newcode133 sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java:133: // TODO(abarth): Which mError.code should we set? the ...
5 years, 10 months ago (2015-02-18 23:38:02 UTC) #5
abarth-chromium
5 years, 10 months ago (2015-02-19 00:53:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9c85fe573cb9eeaecf850f9ed6b26fb89caa8c12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698