Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 930623003: MIPS64: Assembler support for internal references. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Assembler support for internal references. Port 49cbe537e715c960fb9773af2e240133726f465b BUG= Committed: https://crrev.com/01538bffb83c231cf03bc6f9fd0332cf7bfdd193 Cr-Commit-Position: refs/heads/master@{#26700}

Patch Set 1 #

Patch Set 2 : Fix compilation problem. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -25 lines) Patch
M src/mips64/assembler-mips64.h View 1 5 chunks +13 lines, -4 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 11 chunks +67 lines, -16 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 2 chunks +226 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
balazs.kilvady
To build V8 mips64el https://codereview.chromium.org/932683002/ also must be landed.
5 years, 10 months ago (2015-02-16 18:50:05 UTC) #2
balazs.kilvady
32 bit version is just reverted so this patch also must be verified.
5 years, 10 months ago (2015-02-16 18:58:30 UTC) #3
balazs.kilvady
Compilation problem of the 32 bit version which caused a revert is fixed.
5 years, 10 months ago (2015-02-17 09:32:58 UTC) #4
balazs.kilvady
5 years, 10 months ago (2015-02-17 09:33:13 UTC) #5
akos.palfi.imgtec
Lgtm.
5 years, 10 months ago (2015-02-17 12:21:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930623003/20001
5 years, 10 months ago (2015-02-17 15:36:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 16:25:37 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 16:25:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01538bffb83c231cf03bc6f9fd0332cf7bfdd193
Cr-Commit-Position: refs/heads/master@{#26700}

Powered by Google App Engine
This is Rietveld 408576698