Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 93058: Browser Crash when opening urls with NEW_BACKGROUND_TAB disposition... (Closed)

Created:
11 years, 8 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Browser Crash when opening urls with NEW_BACKGROUND_TAB disposition When that disposition is used and no "normal" window is opened, it crashes. "normal" means non POPUP, non APPLICATION window type. This happens because background disposition doens't focus or activate the window unless selected. A crash happens because GetSelectedTabContents() is null since nothing initially there. This fix might have stopped it crash, but would be best to see if its a "good" approach. I fixed some lints such as, header file already exists, extra white space, etc) BUG=10591 ( http://crbug.com/10591 ) Original patch by Mohamed Mansour (see http://codereview.chromium.org/67205/show), r=me,pkasting Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/browser.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698