Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 93053003: Drop icudata from the dependency list from web.gyp (Closed)

Created:
7 years ago by jungshik at Google
Modified:
7 years ago
CC:
blink-reviews
Visibility:
Public.

Description

Drop icudata from the dependency list from web.gyp Specifying icuuc is sufficient because icuuc depends on icudata. Moreover, it causes ninja to complain about multiple rules specified for icudata and a circular dependency when icu_use_data_file_flag is set to 1 on Linux. See also https://codereview.chromium.org/89863002/ BUG=72633 TEST=All types of builds (static, shared, etc) go fine. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/web/web.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jungshik at Google
7 years ago (2013-12-02 17:57:22 UTC) #1
jungshik at Google
This is a companion to https://codereview.chromium.org/89863002/, but landing this in blink first should not affect ...
7 years ago (2013-12-02 17:58:34 UTC) #2
Mark Mentovai
LGTM. This was wrong before.
7 years ago (2013-12-02 18:01:01 UTC) #3
jungshik at Google
Thanks, Mark. Adam, can you approve the change (owner review)? thanks.
7 years ago (2013-12-03 17:43:07 UTC) #4
abarth-chromium
lgtm
7 years ago (2013-12-03 17:57:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/93053003/1
7 years ago (2013-12-03 17:58:08 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 19:24:12 UTC) #7
Message was sent while issue was closed.
Change committed as 163104

Powered by Google App Engine
This is Rietveld 408576698