[S.P.] Add drawing recorder for FrameSetPainter

[S.P.] Add drawing recorder for FrameSetPainter

This patch adds a drawing recorder for FrameSetPainter and adds
fast/frames to the slimming paint virtual test suite.

BUG=458813

[Jin Yang, 2015-02-15 05:26:19]

jin.a.yang@intel.com changed reviewers:
+ chirshtr@chromium.org, pdr@chromium.org

[Jin Yang, 2015-02-15 05:27:03]

jin.a.yang@intel.com changed reviewers:
+ chrishtr@chromium.org
- chirshtr@chromium.org

[Jin Yang, 2015-02-15 05:29:20]

pdr@, PTAL
This CL will import one image failure, that's caused by
BoxPainter::shouldAntialiasLines, mark it as needrebaseline

[Jin Yang, 2015-02-17 01:53:25]

On 2015/02/15 05:29:20, Jin Yang wrote:
> pdr@, PTAL
> This CL will import one image failure, that's caused by
> BoxPainter::shouldAntialiasLines, mark it as needrebaseline

Hi Philip,
could you help review the patch? thanks in advance!

[pdr., 2015-02-17 23:03:21]

In general this looks good, just a minor question about the test expectation
line.

https://codereview.chromium.org/930503003/diff/1/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/930503003/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:28: crbug.com/458813
virtual/slimmingpaint/fast/frames/iframe-scaling-with-scroll.html [
ImageOnlyFailure NeedsManualRebaseline ]
Why is this marked as NeedsManualRebaseline? Maybe you meant to upload the
results you're getting on your platform and then use NeedsRebaseline (no
ImageOnlyFailure) to let the rebaseline bot rebaseline this afterwards?

[chrishtr, 2015-02-25 23:32:26]

On 2015/02/17 at 23:03:21, pdr wrote:
> In general this looks good, just a minor question about the test expectation
line.
> 
> https://codereview.chromium.org/930503003/diff/1/LayoutTests/TestExpectations
> File LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/930503003/diff/1/LayoutTests/TestExpectations...
> LayoutTests/TestExpectations:28: crbug.com/458813
virtual/slimmingpaint/fast/frames/iframe-scaling-with-scroll.html [
ImageOnlyFailure NeedsManualRebaseline ]
> Why is this marked as NeedsManualRebaseline? Maybe you meant to upload the
results you're getting on your platform and then use NeedsRebaseline (no
ImageOnlyFailure) to let the rebaseline bot rebaseline this afterwards?

Ping? Any progress on this CL?

[jbroman, 2015-02-26 00:20:44]

On 2015/02/25 23:32:26, chrishtr wrote:
> On 2015/02/17 at 23:03:21, pdr wrote:
> > In general this looks good, just a minor question about the test expectation
> line.
> > 
> >
https://codereview.chromium.org/930503003/diff/1/LayoutTests/TestExpectations
> > File LayoutTests/TestExpectations (right):
> > 
> >
>
https://codereview.chromium.org/930503003/diff/1/LayoutTests/TestExpectations...
> > LayoutTests/TestExpectations:28: crbug.com/458813
> virtual/slimmingpaint/fast/frames/iframe-scaling-with-scroll.html [
> ImageOnlyFailure NeedsManualRebaseline ]
> > Why is this marked as NeedsManualRebaseline? Maybe you meant to upload the
> results you're getting on your platform and then use NeedsRebaseline (no
> ImageOnlyFailure) to let the rebaseline bot rebaseline this afterwards?
> 
> Ping? Any progress on this CL?

It looks like this is trying to do a thing I already did; see the linked bug:
https://code.google.com/p/chromium/issues/detail?id=458813

[chrishtr, 2015-02-26 00:22:17]

On 2015/02/26 at 00:20:44, jbroman wrote:
> On 2015/02/25 23:32:26, chrishtr wrote:
> > On 2015/02/17 at 23:03:21, pdr wrote:
> > > In general this looks good, just a minor question about the test
expectation
> > line.
> > > 
> > >
https://codereview.chromium.org/930503003/diff/1/LayoutTests/TestExpectations
> > > File LayoutTests/TestExpectations (right):
> > > 
> > >
> >
https://codereview.chromium.org/930503003/diff/1/LayoutTests/TestExpectations...
> > > LayoutTests/TestExpectations:28: crbug.com/458813
> > virtual/slimmingpaint/fast/frames/iframe-scaling-with-scroll.html [
> > ImageOnlyFailure NeedsManualRebaseline ]
> > > Why is this marked as NeedsManualRebaseline? Maybe you meant to upload the
> > results you're getting on your platform and then use NeedsRebaseline (no
> > ImageOnlyFailure) to let the rebaseline bot rebaseline this afterwards?
> > 
> > Ping? Any progress on this CL?
> 
> It looks like this is trying to do a thing I already did; see the linked bug:
https://code.google.com/p/chromium/issues/detail?id=458813

Ah. Let's close this issue then.

[jbroman, 2015-02-26 00:22:35]

jbroman@chromium.org changed reviewers:
+ jbroman@chromium.org

[jbroman, 2015-02-26 00:22:36]

https://codereview.chromium.org/930503003/diff/1/Source/core/paint/FrameSetPa...
File Source/core/paint/FrameSetPainter.cpp (right):

https://codereview.chromium.org/930503003/diff/1/Source/core/paint/FrameSetPa...
Source/core/paint/FrameSetPainter.cpp:38: RenderDrawingRecorder
renderDrawingRecorder(paintInfo.context, m_renderFrameSet, paintInfo.phase,
borderRect);
For future reference, this will produce lots of display items with the same ID,
which the merge/caching algorithm won't like very much.

[Jin Yang, 2015-02-26 02:16:31]

On 2015/02/26 00:22:36, jbroman wrote:
>
https://codereview.chromium.org/930503003/diff/1/Source/core/paint/FrameSetPa...
> File Source/core/paint/FrameSetPainter.cpp (right):
> 
>
https://codereview.chromium.org/930503003/diff/1/Source/core/paint/FrameSetPa...
> Source/core/paint/FrameSetPainter.cpp:38: RenderDrawingRecorder
> renderDrawingRecorder(paintInfo.context, m_renderFrameSet, paintInfo.phase,
> borderRect);
> For future reference, this will produce lots of display items with the same
ID,
> which the merge/caching algorithm won't like very much.

Thanks! I am just back from holiday. Close it as it was fixed in your CL then.
:)